cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From adamduren <...@git.apache.org>
Subject [GitHub] cordova-android pull request: CB-10498: Resume event should be sti...
Date Thu, 04 Feb 2016 06:16:35 GMT
Github user adamduren commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/257#discussion_r51833834
  
    --- Diff: cordova-js-src/platform.js ---
    @@ -58,6 +61,19 @@ module.exports = {
             bindButtonChannel('volumeup');
             bindButtonChannel('volumedown');
     
    +        // The resume event is not "sticky", but it is possible that the event
    +        // will contain the result of a plugin call. We need to ensure that the
    +        // plugin result is delivered even after the event is fired (CB-10498)
    +        var cordovaAddEventListener = document.addEventListener;
    --- End diff --
    
    This is really the original document.addListener. Maybe the name should be changed to
make that more clear.
    
    I think this is a simple and clean solution. However, I am a little weary about monkey
patching `document.addEventListener`. I'm not sure what a better alternative would be though
without adding unnecessary complexity.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message