cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jimmont <...@git.apache.org>
Subject [GitHub] cordova-js pull request: CB-9366 Log error.stack as it helps with ...
Date Wed, 03 Feb 2016 20:18:54 GMT
Github user jimmont commented on the pull request:

    https://github.com/apache/cordova-js/pull/118#issuecomment-179440047
  
    [This try-catch](https://github.com/apache/cordova-js/blob/master/src/cordova.js#L228)
for callbacks is a real pain. Having access to errors as they occur is highly desirable. And
there appears to be [a logic error here](https://github.com/apache/cordova-js/blob/master/src/cordova.js#L223)
where callbacks are never deleted if they throw an error. Isn't managing errors a responsibility
outside of `self.cordova`? Just started looking at this javascript after a *lot* of problematic
worker debugging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message