cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From riknoll <...@git.apache.org>
Subject [GitHub] cordova-docs pull request: CB-10351: Make Events page a reference
Date Tue, 02 Feb 2016 23:02:50 GMT
Github user riknoll commented on a diff in the pull request:

    https://github.com/apache/cordova-docs/pull/480#discussion_r51651548
  
    --- Diff: www/static/js/docs.js ---
    @@ -40,7 +40,7 @@ $(document).ready(function () {
     
         // Table of Contents
         $('#page-toc').toc({
    -        'selectors':         'h1,h2,h3,h4,h5,h6', // elements to use as headings
    +        'selectors':         'h1,h2', // elements to use as headings
    --- End diff --
    
    Confusing for who? I don't think users expect the TOC to be that comprehensive; major
headings only should be fine. We do need to be vigilant when we write pages to make sure the
TOC displays correctly. I would argue that defining/using other tags just complicates the
markdown and defeats the purpose of using it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message