cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From riknoll <...@git.apache.org>
Subject [GitHub] cordova-medic pull request: CB-10474: Fix cordova-ios logging
Date Tue, 02 Feb 2016 20:20:11 GMT
Github user riknoll commented on the pull request:

    https://github.com/apache/cordova-medic/pull/73#issuecomment-178801188
  
    @dblotsky I don't think there is an easy way to get the running simulator, so instead
I am going to move the simulator choosing logic from `cordova run` to medic and pass the `--target`
flag. I'll probably just do the same thing as above, which is choosing the last iPhone that
appears in the list of devices. They list in order (with newest devices appearing at the bottom),
so this method will end up choosing iPhone-6s-plus for now. I'll copy the same function in
medic-run.js and medic-log.js to ensure they choose the same thing. Is that alright with you?
It works for CI, but it will fail on a user's machine if they manually started another simulator
(which shouldn't be a big deal, won't come up on buildbot).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message