cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-10430 Allow to modify events source
Date Tue, 02 Feb 2016 12:45:05 GMT
Github user vladimir-kotikov commented on the pull request:

    https://github.com/apache/cordova-lib/pull/370#issuecomment-178554295
  
    @dblotsky, @purplecabbage, thanks for feedback. Agree, this probably smells fishy. However,
the only one option i see apart from this one is to setup a proxy to transmit events from
`cordova-common` to another `EventEmitter` instance (which was passed to `PlatformApi` constructor),
when necessary.
    
    All other solutions, that came into my mind, break `events` API and hence require some
global changes in cordova (as the `events` is used really widely).
    
    However, this PR doesn't change a public API for this and seems to fix the issue with
missing events from `cordova-common` internals without affecting any other cases, so it might
make sense to get this in as an intermediate fix and then start looking into redesigning cordova
`events` mechanics.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message