cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabbage <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-10430 Allow to modify events source
Date Tue, 02 Feb 2016 07:07:34 GMT
Github user purplecabbage commented on the pull request:

    https://github.com/apache/cordova-lib/pull/370#issuecomment-178414449
  
    Yeah, I too am not entirely behind this.
    It seems like an anti-pattern here, and a consequence of require('../events') only being
executed once per module.  This essentially makes it a global object that may change at runtime.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message