cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From TimBarham <...@git.apache.org>
Subject [GitHub] cordova-windows pull request: don't copy resource-files at plugin ...
Date Mon, 01 Feb 2016 12:49:50 GMT
Github user TimBarham commented on the pull request:

    https://github.com/apache/cordova-windows/pull/139#issuecomment-177957240
  
    I've taken a look too, and I agree this seems the best approach. Changes look good to
me, except I agree with your comment @sgrebnov that we should use a relative path rather than
absolute.
    
    Regarding the red "x" on the folder name: this seems to be a limitation of a `jsproj`
(that they don't fully support links, at least in the VS UI). If you create an equivalent
link in a `csproj`, you don't get the red "x". If it indeed builds fine, then we can live
with that.
    
    However, there is one way we can avoid the red "x": actually create any folder defined
in the `target` path (if there is one). It would be empty, but would make for less confusion
in the VS UI.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message