Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: jcesarmobile <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
Message-ID: <git-pr-137-cordova-plugin-inappbrowser@git.apache.org>
Subject: [GitHub] cordova-plugin-inappbrowser pull request: Fix for CB-10305
Content-Type: text/plain
Date: Sat, 16 Jan 2016 10:54:43 +0000 (UTC)

GitHub user jcesarmobile opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/137

    Fix for CB-10305

    There are really 3 issues here.
    1. When the inAppBrowser is started in portrait and rotates, the
    background of the status bar doesn’t fill the whole area. (any iOS
    version)
    2. On iOS 7, if the inAppBrowser plugin is started on landscape, the
    background of the status bar was vertical.
    3. On iOS 8-9, on iPhone/iPod, the status bar disappears on landscape,
    but the background doesn’t disappear. I’ve changed it to make the
    status bar appear  on landscape too. (This wasn’t on CB-10305, but I
    think it’s related)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jcesarmobile/cordova-plugin-inappbrowser CB-10368

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/137.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #137
    
----
commit 500de94ae968f77c4545f8e6222eac543caf5ef4
Author: Julio César <jcesarmobile@gmail.com>
Date:   2016-01-16T10:45:17Z

    Fix for CB-10305
    
    There are really 3 issues here.
    1. When the inAppBrowser is started in portrait and rotates, the
    background of the status bar doesn’t fill the whole area. (any iOS
    version)
    2. On iOS 7, if the inAppBrowser plugin is started on landscape, the
    background of the status bar was vertical.
    3. On iOS 8-9, on iPhone/iPod, the status bar disappears on landscape,
    but the background doesn’t disappear. I’ve changed it to make the
    status bar appear  on landscape too. (This wasn’t on CB-10305, but I
    think it’s related)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org