Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2430218F1B for ; Fri, 29 Jan 2016 23:58:33 +0000 (UTC) Received: (qmail 93536 invoked by uid 500); 29 Jan 2016 23:58:32 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 93497 invoked by uid 500); 29 Jan 2016 23:58:32 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 93483 invoked by uid 99); 29 Jan 2016 23:58:32 -0000 Received: from Unknown (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Jan 2016 23:58:32 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 028881A04C1 for ; Fri, 29 Jan 2016 23:58:32 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.9 X-Spam-Level: ** X-Spam-Status: No, score=2.9 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 7kup6gR9hTx6 for ; Fri, 29 Jan 2016 23:58:20 +0000 (UTC) Received: from mail-io0-f180.google.com (mail-io0-f180.google.com [209.85.223.180]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with ESMTPS id 85A3631ACD for ; Fri, 29 Jan 2016 23:58:19 +0000 (UTC) Received: by mail-io0-f180.google.com with SMTP id f81so105292858iof.0 for ; Fri, 29 Jan 2016 15:58:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=SiotbuzcMdM0RkqfIYXb1sR+PRca3zNzzjEgmtxizlE=; b=hH/AniHHgE8dP9dIPnloEIBpMQVvKX1DaAS6GzDhmJUKnz7BUGB+GTuHQXCZxsOEp8 OMTu3GjFvU+JB5vc9hGkCbHnDs9Kj7mbGneb1uSvI+yBABjZfufIJPvwCG1sUqMFQ22x jFa2it9ztkBUYmPqFk4sq+XtdoqtCCktaltDjbNAEU6fzVeotxEhZQqgtj/iHTm3M3/K yKVlnUgunux+nk+7PjSPudGi7oy9p7buQvaVAwf5VZ53wvA4p4VELSoiWkTecvZW89UO InhGXK1MzX9pAy+vjnFfV1TT+NrHqU+LzE7OXl01pfFTRjVOpFWbSKx86jVe1Buelpq8 gTrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type; bh=SiotbuzcMdM0RkqfIYXb1sR+PRca3zNzzjEgmtxizlE=; b=jpPLgNyeGNDEO6b6h1kLIi/aIO4N2hybvmu/21bIimk+zxo3PUfEBQuEiz0RFuGNyW 2D0YyU/o/klpj+6TdFctf2pjmGPbImeOZC+9IVVaBlUhrryi5alZrCsTBgEf5tMf996t mqpZWAOkIsFQ2KzcnmoRDk1CNTNgV/ds2VURi0JrqftZlxYwL3fMCccTMBYTV5mpvQYL BxYS6B6NTzEipoTIe4cNAp5YrnbiPLPPlCP6cbaG6hMSfQ0CmWoxAl74D2yIaRIUl77E mi3K9zLayRRPgx82ffez6q6JKh+SLl3dsBI+om4wF9aBFWukCqa8ERJpa4GyL/BACtlf UlJA== X-Gm-Message-State: AG10YOR/xf+CjfoQtYiqMg7D5gdFcWwpa6q0gAhi66eFXI0qVGh5Dm2B4sWcXfBpJQgLmmU4CXu1n12HECmVAw== MIME-Version: 1.0 X-Received: by 10.107.36.83 with SMTP id k80mr15022808iok.140.1454111898545; Fri, 29 Jan 2016 15:58:18 -0800 (PST) Received: by 10.64.124.132 with HTTP; Fri, 29 Jan 2016 15:58:18 -0800 (PST) In-Reply-To: References: Date: Fri, 29 Jan 2016 16:58:18 -0700 Message-ID: Subject: Re: help running android native tests From: Joe Bowser To: dev Content-Type: multipart/alternative; boundary=001a11402f202d34a0052a81cf64 --001a11402f202d34a0052a81cf64 Content-Type: text/plain; charset=UTF-8 Yeah, it looks like the behaviour has changed since this was run. I have a feeling that someone "refactored" and "cleaned up" the tests and the original intent of this test was lost. So, yeah, this should have an intent provided to it, and this test should fail. The tests definitely need to be looked at again and their usefulness re-evaluated. On Fri, Jan 29, 2016 at 4:35 PM, Homer, Tony wrote: > HtmlNotFoundTest fails for me too. > > Is it a problem that the CordovaActivity displays an error dialog? > If it is, we could override displayError in MainTestActivity. > > Maybe it's simpler than that - should the test be setting an errorUrl and > then asserting that the errorUrl has been loaded? > If no errorUrl is set, testActivity.getCordovaWebView().getUrl() would > still be equal to START_URL, wouldn't it? > > > In that case the current assertion should fail (and the test would fail). > > On 1/29/16, 5:16 PM, "Joe Bowser" wrote: > > >Run it a few times to be sure it's failing. This test shouldn't fail, but > >isn't as stable as it should be. > > > >On Fri, Jan 29, 2016, 2:41 PM Carlos Santana > wrote: > > > >> I working on getting my environment and all test pass except for one > >> > >> junit.framework.AssertionFailedError > >> at > org.apache.cordova.test.HtmlNotFoundTest$1.run(HtmlNotFoundTest.java:36) > >> at > >> > >> > android.test.InstrumentationTestCase$1.run(InstrumentationTestCase.java:138) > >> at > android.app.Instrumentation$SyncRunnable.run(Instrumentation.java:1871) > >> at android.os.Handler.handleCallback(Handler.java:739) > >> at android.os.Handler.dispatchMessage(Handler.java:95) > >> at android.os.Looper.loop(Looper.java:135) > >> at android.app.ActivityThread.main(ActivityThread.java:5254) > >> at > >> > >> > com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903) > >> at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698) > >> > >> Are the tests wrong, or my setup missing something I followed the > >> instructions in the README.md in the test folder > >> > >> > >> [1]: > https://github.com/apache/cordova-android/blob/master/test/README.md > >> > --001a11402f202d34a0052a81cf64--