Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BE5D618E11 for ; Wed, 27 Jan 2016 02:34:31 +0000 (UTC) Received: (qmail 46684 invoked by uid 500); 27 Jan 2016 02:34:31 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 46645 invoked by uid 500); 27 Jan 2016 02:34:31 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 46634 invoked by uid 99); 27 Jan 2016 02:34:31 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Jan 2016 02:34:31 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id E387CE00D6; Wed, 27 Jan 2016 02:34:30 +0000 (UTC) From: dblotsky To: dev@cordova.apache.org Reply-To: dev@cordova.apache.org References: In-Reply-To: Subject: [GitHub] cordova-windows pull request: CB-10440 Add CSS color names support... Content-Type: text/plain Message-Id: <20160127023430.E387CE00D6@git1-us-west.apache.org> Date: Wed, 27 Jan 2016 02:34:30 +0000 (UTC) Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/142#discussion_r50934535 --- Diff: template/cordova/lib/AppxManifest.js --- @@ -374,6 +374,11 @@ AppxManifest.prototype.getCapabilities = function () { }; function refineColor(color) { + if (color.indexOf('0x') === -1 && color.indexOf('#') === -1) { --- End diff -- Please put this condition into a function; that way it will be easier to debug and read in the future. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org For additional commands, e-mail: dev-help@cordova.apache.org