Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3434C18BEF for ; Fri, 22 Jan 2016 02:25:59 +0000 (UTC) Received: (qmail 67523 invoked by uid 500); 22 Jan 2016 02:25:58 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 67479 invoked by uid 500); 22 Jan 2016 02:25:58 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 67467 invoked by uid 99); 22 Jan 2016 02:25:58 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Jan 2016 02:25:58 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 920B3DFF94; Fri, 22 Jan 2016 02:25:58 +0000 (UTC) From: njleonzhang To: dev@cordova.apache.org Reply-To: dev@cordova.apache.org References: In-Reply-To: Subject: [GitHub] cordova-plugin-splashscreen pull request: make android support Aut... Content-Type: text/plain Message-Id: <20160122022558.920B3DFF94@git1-us-west.apache.org> Date: Fri, 22 Jan 2016 02:25:58 +0000 (UTC) Github user njleonzhang commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/71#issuecomment-173780749 @daserge, I don't think this will cause memory leak. In addition, it doesn't make sense to hide the splash, if you have disabled AutoHideSplashScreen. For example, when an application init, it try to access the network, if the network is shutdown, application may pop a alert to ask user to check network config and then click retry button in the dialog. This is a popular normal scenario. In this situation, user switch the application to background, and turn on the wifi, then switch back to our application. They will find the splash is closed........ at this moment, the App is not inited, so it may be a white screen with a pop up alert dialog. surprise? If you think this code change may cause memory leak, I think we should involve some expert to review the code. If it do cause memory leak, we should provide another solution for this issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org For additional commands, e-mail: dev-help@cordova.apache.org