Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 59AD418504 for ; Tue, 19 Jan 2016 19:55:18 +0000 (UTC) Received: (qmail 53014 invoked by uid 500); 19 Jan 2016 19:55:18 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 52992 invoked by uid 500); 19 Jan 2016 19:55:18 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 52981 invoked by uid 99); 19 Jan 2016 19:55:17 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Jan 2016 19:55:17 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id A9FEBE0098; Tue, 19 Jan 2016 19:55:17 +0000 (UTC) From: riknoll To: dev@cordova.apache.org Reply-To: dev@cordova.apache.org References: In-Reply-To: Subject: [GitHub] cordova-plugin-camera pull request: Android FileHelper modificatio... Content-Type: text/plain Message-Id: <20160119195517.A9FEBE0098@git1-us-west.apache.org> Date: Tue, 19 Jan 2016 19:55:17 +0000 (UTC) Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/149#discussion_r50165621 --- Diff: src/android/FileHelper.java --- @@ -79,50 +79,72 @@ public static String getRealPath(String uriString, CordovaInterface cordova) { @SuppressLint("NewApi") public static String getRealPathFromURI_API19(Context context, Uri uri) { String filePath = ""; + Cursor cursor = null; + try { - String wholeID = DocumentsContract.getDocumentId(uri); + String wholeID = DocumentsContract.getDocumentId(uri); // Split at colon, use second item in the array String id = wholeID.indexOf(":") > -1 ? wholeID.split(":")[1] : wholeID.indexOf(";") > -1 ? wholeID .split(";")[1] : wholeID; - String[] column = { MediaStore.Images.Media.DATA }; + // @dlogo 20151210 Get type to check wheter is image or video + String type = wholeID.indexOf(":") > -1 ? wholeID.split(":")[0] : wholeID.indexOf(";") > -1 ? wholeID + .split(";")[0] : wholeID; + + Uri contentUri = null; + if ("image".equals(type)) { + contentUri = MediaStore.Images.Media.EXTERNAL_CONTENT_URI; + } else if ("video".equals(type)) { + contentUri = MediaStore.Video.Media.EXTERNAL_CONTENT_URI; + } else if ("audio".equals(type)) { + contentUri = MediaStore.Audio.Media.EXTERNAL_CONTENT_URI; + } + + String[] column = { "_data" }; --- End diff -- Instead of hardcoding "_data", it looks like you can reference it from the base class that images/video/audio inherit from http://developer.android.com/reference/android/provider/MediaStore.MediaColumns.html --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org For additional commands, e-mail: dev-help@cordova.apache.org