cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From guillaumedev <...@git.apache.org>
Subject [GitHub] cordova-plugin-geolocation pull request: Update iOS geolocation pl...
Date Wed, 20 Jan 2016 20:56:47 GMT
GitHub user guillaumedev opened a pull request:

    https://github.com/apache/cordova-plugin-geolocation/pull/67

    Update iOS geolocation plugin to avoid THREAD WARNING: ['Geolocation'…

    To avoid warning  "THREAD WARNING: ['Geolocation'] took 'X' ms. Plugin should use a background
thread.", i added     [self.commandDelegate runInBackground:^{ }]; around the code in getLocation
method. By doing so, the execution of this code takes place in a new thread and works all
the same. 
    
    Apple sometimes can reject application because of that, so it can only be good to add
it, as simple as it is.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/guillaumedev/cordova-plugin-geolocation master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-geolocation/pull/67.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #67
    
----
commit 8fbceca845441f4f421548f243d2f05573d11225
Author: Guillaumedev <contact@guillaumedev.com>
Date:   2016-01-20T20:47:40Z

    Update iOS geolocation plugin to avoid THREAD WARNING: ['Geolocation'], operation occurs
in new Thread

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message