cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From riknoll <>
Subject [GitHub] cordova-plugin-geolocation pull request: CB-10319 android: Adding ...
Date Tue, 12 Jan 2016 01:19:38 GMT
GitHub user riknoll opened a pull request:

    CB-10319 android: Adding reflective helper methods for permission requests

    Adds reflection helper class as was discussed on the mailing list. I ran the mobilespec
auto tests with cordova-android's master branch and cordova-android 3.7.2 and seemed to get
the same output as the vanilla mobilespec. I couldn't get the manual tests to work, so I did
not run those. All tests were run on a nexus 6 running Marshmallow; I might do some extra
testing on an emulator with a lower API level in a bit. @infil00p @jasongin please review.

You can merge this pull request into a Git repository by running:

    $ git pull reflection

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #66
commit 9420f405f64fded667eb8335fc9cddc2401d6ff3
Author: riknoll <>
Date:   2016-01-11T19:06:37Z

    CB-10319 android: Adding reflective helper methods for permission requests


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message