cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabbage <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-10423 Recursive error in plugin add (...
Date Sun, 24 Jan 2016 03:56:45 GMT
GitHub user purplecabbage opened a pull request:

    https://github.com/apache/cordova-lib/pull/364

    CB-10423 Recursive error in plugin add ( windows )

    repro steps ;
    in a plugin repo that has a demo project, you may want to do something like this to allow
other developers to run the demo:
    cd demo
    cordova plugin add ../ 
    
    windows does not allow symlink unless the shell is run with administrator privileges,
which means the fix for [CB-8809] will still fail in most cases.
    
    The root of the problem is that we are attempting to copy src->dest when src contains
dest, so we CAN proceed as long as we skip the destination folder from source.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/purplecabbage/cordova-lib CB-10423

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/364.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #364
    
----
commit 0d195d41c0cb9fb960e06789c02fecd9e69a0c25
Author: Jesse MacFadyen <purplecabbage@gmail.com>
Date:   2016-01-24T03:52:44Z

    allow recursive folder copy skipping whatever .. was

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message