cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tony-- <...@git.apache.org>
Subject [GitHub] cordova-android pull request: fix HtmlNotFoundTest so that it pass...
Date Sat, 30 Jan 2016 02:32:13 GMT
GitHub user tony-- opened a pull request:

    https://github.com/apache/cordova-android/pull/256

    fix HtmlNotFoundTest so that it passes when file not found is handled correctly

    override displayError in testActivity to send message to queue (dialogs are not very useful
in tests)
    evaluate message to make sure it contains ERR_FILE_NOT_FOUND and the (invalid) START_URL

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tony--/cordova-android fixHtmlNotFoundTest

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-android/pull/256.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #256
    
----
commit 4730d9fc6348e4a030c10ec1a7a203bbe96c45fe
Author: Tony Homer <tony.homer@intel.com>
Date:   2016-01-30T02:28:07Z

    fix HtmlNotFoundTest so that it passes when file not found is handled correctly

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message