cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mitko-Kerezov <...@git.apache.org>
Subject [GitHub] cordova-android pull request: Parse options correctly
Date Wed, 06 Jan 2016 16:11:07 GMT
GitHub user Mitko-Kerezov opened a pull request:

    https://github.com/apache/cordova-android/pull/248

    Parse options correctly

    Fix 1
    Options have already passed through `nopt` module in the build file. Nopt successfully
parses all options which results in `argv.remain` being an empty array.
    This ultimately leads to a bug in the `parseOpts` function where the options undergo a
second parsing from nopt, whereas they are actually ready to be consumed.
    The end result is - this options are not respected at all.
    
    Fix 2
    parseOpts function referenced `this.root` but the `this` object is not the `new Api` as
expected. This leads to an exception upon calling `path.relative(this.root, ...)`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Icenium/cordova-android kerezov/fix-parse-options

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-android/pull/248.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #248
    
----
commit c1651fd6dd49c6a5a46eaf8a88400b06fa164ab1
Author: Dimitar Kerezov <dimitar.kerezov@telerik.com>
Date:   2016-01-06T15:26:06Z

    Parse options correctly
    
    Fix #1
    Options have already passed through `nopt` module in the build file. Nopt successfully
parses all options which results in `argv.remain` being an empty array.
    This ultimately leads to a bug in the `parseOpts` function where the options undergo a
second parsing from nopt, whereas they are actually ready to be consumed.
    
    Fix #2
    parseOpts function referenced `this.root` but the `this` object is not the `new Api` as
expected. This leads to an exception upon calling `path.relative(this.root, ...)`.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message