cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From uareurapid <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser pull request: handle app store urls in...
Date Tue, 05 Jan 2016 12:43:02 GMT
GitHub user uareurapid opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/133

    handle app store urls in system browser

    I´ve found the following situation (on IOS app)...
    
    I navigate to some website that has links to app store apps...
    
    If the browser finds "https://itunes.apple.com" links they are turned into "itms-appss://"
or "itms-apps://" and the browser fails to load them because it doesn´t know to handle them.
    
    These should be opened in system browser and the webview should give up on them, cause
it will fail to process them

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/uareurapid/cordova-plugin-inappbrowser master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/133.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #133
    
----
commit fa7c46a316fa4b773aa75742d9ceb10c40056e53
Author: PC Dreams (Paulo Cristo) <cristo.paulo@gmail.com>
Date:   2016-01-05T12:32:47Z

    handle app store urls in system browser

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message