cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Richard Knoll <>
Subject RE: [REVIEW] CB-10472 NullPointerException: org.apache.cordova.PluginManager.onSaveInstanceState
Date Fri, 29 Jan 2016 01:01:09 GMT
I also think we should add tests for this. Carlos, do you have a setup for this bug that you
could share? It would be nice to have mobilespec tests for save/restore in general, but that
ends up being sort of tricky because it requires enabling the "Don't Keep Activities" dev


-----Original Message-----
From: Joe Bowser [] 
Sent: Thursday, January 28, 2016 1:39 PM
To: dev <>
Subject: Re: [REVIEW] CB-10472 NullPointerException: org.apache.cordova.PluginManager.onSaveInstanceState

LGTM, but we should have a unit test to cover this behaviour somehow.

On Thu, Jan 28, 2016 at 2:23 PM, Carlos Santana <>

> It's being a while since I have done Android native dev, Can someone 
> review the PR I sent
> This hit us today at work, we have a complex launch of multiple 
> Cordova Activities to deal with security aspects and crosswalk.
> It's only in cordova-android@5.1.0 due to the recent changes for 
> saveState and restoreState for plugins
> It will be great to release a 5.1.1 next week with a couple of other 
> bugs that are already seating in master.

To unsubscribe, e-mail:
For additional commands, e-mail:
View raw message