cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Steven Gill <stevengil...@gmail.com>
Subject Re: [DISCUSS] Android@5.1.0
Date Thu, 21 Jan 2016 19:13:37 GMT
Sounds great! I'll post the blog for review soon and would love for you to
add a little blurb about this in it.

For docs, I say merge it in and I can update the site. It would fall into
the `dev` branch unless you explicitly add the changes to 5.4.0 docs folder
as well.

I plan on cutting a 6.0.0 for docs with cordova 6.0.0 release.




On Thu, Jan 21, 2016 at 11:01 AM, Richard Knoll <riknoll@microsoft.com>
wrote:

> When this release goes out, I think it's a good idea for us to point to
> the new Android Lifecycle Guide I added to the docs in the blog post.
>
>
> http://cordova.apache.org/docs/en/dev/guide/platforms/android/lifecycle.html
>
> I also have a PR open that improves it here:
>
> https://github.com/apache/cordova-docs/pull/461
>
> The documentation is necessary for using some of the fixes that
> cordova-android 5.1.0 brings to the camera and contacts plugins. The camera
> bug in particular [1] is a pretty common issue that people run into (gets a
> lot of Jira activity and duplicate issues). It would also be nice if we
> could do a minor docs release to move that guide out of dev and into latest
> once I merge that PR. I don't mind writing something up about the changes
> for the blog post.
>
> [1] https://issues.apache.org/jira/browse/CB-9189
>
> Thanks,
> Richard
>
> -----Original Message-----
> From: Steven Gill [mailto:stevengill97@gmail.com]
> Sent: Tuesday, January 19, 2016 12:22 PM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] Android@5.1.0
>
> Looks like it has been merged. Good to release now?
>
> On Tue, Jan 19, 2016 at 11:57 AM, Joe Bowser <bowserj@gmail.com> wrote:
>
> > OK, that's fine for now, but we should look at moving up which Android
> > Gradle version we're building with.  I'm kind of hesitant to use 2.0.0
> > because it might break stuff, and more and more getting the feeling
> > that the tools team is trying to make it harder for us to do things.
> >
> > On Tue, Jan 19, 2016 at 11:17 AM, Nikhil Khandelwal <
> > nikhilkh@microsoft.com>
> > wrote:
> >
> > > We have customers who have an existing C++ code base and looking to
> > > use NDK in their plugins.
> > >
> > > From what I can see the property android.useDeprecatedNdk=true needs
> > > to
> > be
> > > part of
> > > https://na01.safelinks.protection.outlook.com/?url=gradle.properties
> > > &data=01%7c01%7cRIKNOLL%40exchange.microsoft.com%7c43a692ae31ef4ec60
> > > 53008d3210e44a3%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=MAOa7ZH
> > > GBt7D312c1h8nSIsAxPW6PVuKC3SMQ2NJVVc%3d and not .gradle file itself.
> > > I am aware that a plugin can add .gradle files - but I'm not sure
> > > they can add a
> > > https://na01.safelinks.protection.outlook.com/?url=gradle.properties
> > > &data=01%7c01%7cRIKNOLL%40exchange.microsoft.com%7c43a692ae31ef4ec60
> > > 53008d3210e44a3%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=MAOa7ZH
> > > GBt7D312c1h8nSIsAxPW6PVuKC3SMQ2NJVVc%3d file. Of course, hooks can
> > > be used to just about
> > anything
> > > but it sounds hacky.
> > >
> > > Another option would be to have cordova build.js invoke the gradle
> > > compiler with -Pandroid.useDeprecatedNdk=true.
> > >
> > > I have a PR for this:
> > > https://github.com/apache/cordova-android/pull/249
> > >
> > > Let's release once we are OK with merging this.
> > >
> > > -Nikhil
> > >
> > > -----Original Message-----
> > > From: Joe Bowser [mailto:bowserj@gmail.com]
> > > Sent: Tuesday, January 19, 2016 10:36 AM
> > > To: dev@cordova.apache.org
> > > Subject: Re: [DISCUSS] Android@5.1.0
> > >
> > > Yes, it probably can. I'm thinking that Google once again put us in
> > > dependency hell with the new NDK functionality, which is why I'm not
> > super
> > > stoked about this file existing at all.
> > >
> > > On Tue, Jan 19, 2016, 10:29 AM Simon MacDonald <
> > simon.macdonald@gmail.com>
> > > wrote:
> > >
> > > > Can't the crosswalk plugin deliver the Gradle files via the
> > > > framework tag of its plugin. Xml to fix this?
> > > >
> > > > Simon
> > > > On Jan 19, 2016 13:26, "Joe Bowser" <bowserj@gmail.com> wrote:
> > > >
> > > > > I really don't want to add this file and use the deprecated NDK,
> > > > especially
> > > > > since we don't know if this is a plugin or platform responsibility.
> > > > > I
> > > > also
> > > > > don't want to delay a release for people not using Crosswalk.
> > > > >
> > > > > Do we know of any other plugins that use the NDK? If there
> > > > > aren't any,
> > > > I'm
> > > > > more agreeable to adding the file since it won't break others.
> > > > >
> > > > >
> > > > > On Tue, Jan 19, 2016, 10:13 AM Nikhil Khandelwal
> > > > > <nikhilkh@microsoft.com
> > > > >
> > > > > wrote:
> > > > >
> > > > > > If this is a regression in behavior and CrossWalk will not
> > > > > > work out of
> > > > > the
> > > > > > box - we should consider fixing it. Sounds like it is a simple
> > > > > > fix. Is there  JIRA for this?
> > > > > >
> > > > > > Overall, we shouldn't require/expect Cordova JS developers to
> > > > > > modify gradle files.
> > > > > >
> > > > > > -Nikhil
> > > > > >
> > > > > > -----Original Message-----
> > > > > > From: Carlos Santana [mailto:csantana23@gmail.com]
> > > > > > Sent: Tuesday, January 19, 2016 9:00 AM
> > > > > > To: dev <dev@cordova.apache.org>
> > > > > > Subject: Re: [DISCUSS] Android@5.1.0
> > > > > >
> > > > > > What you guys think of making MIN SDK VER 15 instead of 14 as
> > > > > > the
> > > > default
> > > > > > for this Android@5.1.0 ?
> > > > > >
> > > > > > We have a couple of plugins that required minsdk 15 [1], I
> > > > > > also see
> > > > that
> > > > > > phonegap push plugin have problems with min sdk 14 here [2]
> > > > > >
> > > > > > Instead of anoying user with readme instructions to change it
> > > > > > to 15,
> > > > why
> > > > > > not make the default 15, this way more stuff would work out
of
> > > > > > the box
> > > > > with
> > > > > > less trouble.
> > > > > > I guess if there is someone for a particular reason wants
> > > > > > minsdk 14,
> > > > they
> > > > > > can change the default the same way as today using config.xml
> > > > > >
> > > > > >
> > > > > > [1]:
> > > > > >
> > > > > >
> > > > >
> > > > https://github.com/ibm-bluemix-mobile-services/bms-clientsdk-cordo
> > > > va-p
> > > > lugin-push/blob/master/README.md
> > > > > > [2]:
> > > > > >
> > > > > >
> > > > >
> > > > https://github.com/phonegap/phonegap-plugin-push/blob/master/docs/
> > > > INST
> > > > https://na01.safelinks.protection.outlook.com/?url=ALLATION.md&dat
> > > > a=01%7c01%7cRIKNOLL%40exchange.microsoft.com%7c43a692ae31ef4ec6053
> > > > 008d3210e44a3%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=x6Cs9nQ
> > > > HqBiVzPVb9vgl3HXb8h0cFmftyZE5cNURxjU%3d#minsdkversion--14
> > > > > >
> > > > > > On Mon, Jan 18, 2016 at 6:38 PM Joe Bowser <bowserj@gmail.com>
> > > wrote:
> > > > > >
> > > > > > > I don't think the gradle build issue should block the
> > > > > > > release, as annoying as it is, the workaround is literally
> > > > > > > adding a
> > > > > > >
> > > > > >
> > > > >
> > > > https://na01.safelinks.protection.outlook.com/?url=gradle.properti
> > > > es&d
> > > > ata=01%7c01%7cnikhilkh%40microsoft.com%7c08ad0056c7e24290e0e508d32
> > > > 0f20
> > > > 60f%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=Ifi7afmy86ZZTmwxU
> > > > jkWa
> > > > 7guies16P67hnK7hD%2b4hSs%3d
> > > > > > file with a single line.
> > > > > > >
> > > > > > > As far as who owns it, I think Cordova should probably
own
> > > > > > > that, but are there any other plugins that need NDK support?
> > > > > > >
> > > > > > > (I just ran into this less than an hour ago. It's annoying
> > > > > > > that
> > > > Google
> > > > > > > deprecates something without something else to replace
it.)
> > > > > > >
> > > > > > > On Mon, Jan 18, 2016 at 3:34 PM, Darryl Pogue
> > > > > > > <darryl@dpogue.ca>
> > > > > wrote:
> > > > > > >
> > > > > > > > With cordova-android master, the Crosswalk Webview
plugin
> > > > > > > > fails to build because gradle was updated and now
NDK
> > > > > > > > support has been
> > > > > removed.
> > > > > > > >
> > > > > > > > It can be re-enabled by providing a
> > > > > > > >
> > > > https://na01.safelinks.protection.outlook.com/?url=gradle.properti
> > > > es
> > > > > > > > &data=01%7c01%7cnikhilkh%40microsoft.com
> > > > >
> > > > %7c08ad0056c7e24290e0e508d320f2060f%7c72f988bf86f141af91ab2d7cd011
> > > > db47 %7c1&sdata=Ifi7afmy86ZZTmwxUjkWa7guies16P67hnK7hD%2b4hSs%3d
> > > > > > file, but I'm not sure whether that should be the
> > > > > > responsibility of Cordova-Android or the Crosswalk Webview
> plugin.
> > > > > > > >
> > > > > > > > On 18 January 2016 at 15:12, Steven Gill
> > > > > > > > <stevengill97@gmail.com>
> > > > > > wrote:
> > > > > > > >
> > > > > > > > > Going to start this today. Let me know if you
have any
> > > concerns.
> > > > > > > > >
> > > > > > > > > -Steve
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message