cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Robert Posener <rposen...@gmail.com>
Subject Re: [GitHub] cordova-windows pull request: CB-10440 Add CSS color names support...
Date Wed, 27 Jan 2016 03:04:22 GMT
Or is it platform dependent (ie, is the list of colours dependent upon the
WebView implementation)?  So, when the WebView is revised, it will take
care of allowing new colours, instead of developers pointing the finger at
Cordova for not keeping up-to-date with revised colour names?

Rob

Regards
*Rob Posener*
0419 012 627

On 27 January 2016 at 13:35, dblotsky <git@git.apache.org> wrote:

> Github user dblotsky commented on a diff in the pull request:
>
>
> https://github.com/apache/cordova-windows/pull/142#discussion_r50934617
>
>     --- Diff: template/cordova/lib/AppxManifest.js ---
>     @@ -374,6 +374,11 @@ AppxManifest.prototype.getCapabilities = function
> () {
>      };
>
>      function refineColor(color) {
>     +    if (color.indexOf('0x') === -1 && color.indexOf('#') === -1) {
>     --- End diff --
>
>     Is there a list of valid CSS colours? For example, `meow` and `12345`
> and are not colours, but they will get accepted here.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message