cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sgrebnov <...@git.apache.org>
Subject [GitHub] cordova-windows pull request: don't copy resource-files at plugin ...
Date Fri, 29 Jan 2016 12:45:21 GMT
Github user sgrebnov commented on the pull request:

    https://github.com/apache/cordova-windows/pull/139#issuecomment-176733241
  
    I've tried this approach and it seems to work very well. The only two things I've noticed
are:
    1. Generated `Include` is absolute, this could be a problem for remote build tools and
when you move the app or send someone else. But I think this could be easily fixed.
    ```
    <Content Condition="'$(Platform)'=='x64'" Include="C:\temp\resCopyTest\plugins\cordova-plugin-dialogs\dll\x64\foo.dll">
        <Link>x64/foo.dll</Link>
        <CopyToOutputDirectory>Always</CopyToOutputDirectory>
    </Content>
    ```
    2. Includes to files which are outside the VS project are showed like linked folder is
missing so this may confuse people
    ![image](https://cloud.githubusercontent.com/assets/981580/12675912/d74da02a-c69e-11e5-871b-844b37729d8a.png)
    
    But in general this works well and should simplify working with arch-specific native dependencies
a lot. File is correctly placed in generated package so there should no be any runtime issues


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message