cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From riknoll <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request: [CB-10388] - Added correctOrie...
Date Fri, 29 Jan 2016 02:21:52 GMT
Github user riknoll commented on the pull request:

    https://github.com/apache/cordova-plugin-camera/pull/158#issuecomment-176528759
  
    Thanks for submitting a PR! The ALLMEDIA thing definitely sounds like a bug and your change
there looks good.
    
    However, I'm not 100% sure about the changes you made to `getImageOrientation()`. The
issue is that when we get an image URI, it may or may not map to an actual file location depending
on the application that provided the URI. For example, Google Photos can provide URIs that
point to images in the cloud and not on the physical device. In this case, using the content
resolver is the correct method for getting the orientation because the content resolver knows
how to handle those situations. Thoughts?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message