cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mitko-Kerezov <...@git.apache.org>
Subject [GitHub] cordova-android pull request: Parse options correctly
Date Thu, 28 Jan 2016 08:02:39 GMT
Github user Mitko-Kerezov commented on the pull request:

    https://github.com/apache/cordova-android/pull/248#issuecomment-176044525
  
    @vladimir-kotikov 
    I've restructured the fixes and have separated them in two commits.
    Regarding the options I've considered your words and have taken a different approach.
    I didn't know that `cordova build android -- --ant` was meant to be used that way, however
`platforms/android/cordova/build --ant` does not work for `cordova-android@5.0.0`.
    It does work however for the previous `cordova-android@4.1.1`.
    I've backtracked a bit in the commits before your [major refactoring](400282282f21c07bda5527e4c2266810fe01da3f)
and have come across the [previous implementation](https://github.com/apache/cordova-android/blob/789c505a88a6bd2c7c5be596908c85681e457132/bin/templates/cordova/build#L36).
    By passing `args.slice(2)` all options have been passed to the build script. This is why
I've passed `original` instead of `remain`. Moreover nopt seems to parse all options and leaves
nothing inside remain even if `--` delimiter is passed which is somewhat strange but something
to live with I guess.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message