cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nikhilkh <...@git.apache.org>
Subject [GitHub] cordova-windows pull request: CB-10440 Add CSS color names support...
Date Wed, 27 Jan 2016 05:58:13 GMT
Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/142#discussion_r50944308
  
    --- Diff: template/cordova/lib/AppxManifest.js ---
    @@ -374,6 +374,11 @@ AppxManifest.prototype.getCapabilities = function () {
     };
     
     function refineColor(color) {
    +    if (color.indexOf('0x') === -1 && color.indexOf('#') === -1) {
    --- End diff --
    
    WIndows SDK will do the validation and omit errors for invalid values and it's not for
us to validate here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message