cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From riknoll <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: New plugin version selection implementat...
Date Tue, 26 Jan 2016 23:09:58 GMT
Github user riknoll commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/363#discussion_r50916949
  
    --- Diff: cordova-lib/src/cordova/plugin.js ---
    @@ -122,25 +123,6 @@ module.exports = function plugin(command, targets, opts) {
                             var id = parts[0];
                             var version = parts[1];
     
    -                        // If no version is specified, retrieve the version (or source)
from config.xml
    -                        if (!version && !cordova_util.isUrl(id) && !cordova_util.isDirectory(id))
{
    -                            events.emit('verbose', 'no version specified, retrieving
version from config.xml');
    -                            var ver = getVersionFromConfigFile(id, cfg);
    -
    -                            if (cordova_util.isUrl(ver) || cordova_util.isDirectory(ver))
{
    -                                target = ver;
    -                            } else {
    -                                //if version exists from config.xml, use that
    -                                if(ver) {
    -                                    target = ver ? (id + '@' + ver) : target;
    -                                } else {
    -                                    //fetch pinned version from cordova-lib
    -                                    var pinnedVer = pkgJson.cordovaPlugins[id];
    -                                    target = pinnedVer ? (id + '@' + pinnedVer) : target;
    -                                }
    -                            }
    -                        }
    -
                             // Fetch the plugin first.
                             events.emit('verbose', 'Calling plugman.fetch on plugin "' +
target + '"');
    --- End diff --
    
    Yup, this line should have been moved down with the rest


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message