cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dblotsky <...@git.apache.org>
Subject [GitHub] cordova-medic pull request: CB-10405 - Connectivity issue to Cordo...
Date Fri, 22 Jan 2016 01:35:08 GMT
Github user dblotsky commented on a diff in the pull request:

    https://github.com/apache/cordova-medic/pull/72#discussion_r50492408
  
    --- Diff: medic/medic-run.js ---
    @@ -44,7 +44,9 @@ var MEDIC_BUILD_PREFIX        = "medic-cli-build";
     var DEFAULT_WINDOWS_VERSION   = "store";
     var WINDOWS_VERSION_CHOICES   = ["store", "store80", "phone"];
     var DEFAULT_TIMEOUT           = 600; // in seconds
    -var SERVER_RESPONSE_TIMEOUT   = 3000; // in milliseconds
    +var SERVER_RESPONSE_TIMEOUT   = 15000; // in milliseconds
    +var MAX_NUMBER_OF_TRIES       = 3;
    +var WAIT_TIME_FOR_CORDOVA_VM  = 15000; // in milliseconds
    --- End diff --
    
    Sorry, small nitpick again: this name doesn't describe what we're waiting for. Specifically,
we're waiting for some time before retrying.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message