cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dblotsky <...@git.apache.org>
Subject [GitHub] cordova-medic pull request: CB-10405 - Connectivity issue to Cordo...
Date Fri, 22 Jan 2016 00:50:32 GMT
Github user dblotsky commented on a diff in the pull request:

    https://github.com/apache/cordova-medic/pull/72#discussion_r50489182
  
    --- Diff: medic/medic-run.js ---
    @@ -291,6 +293,29 @@ function failedBecauseNoDevice(output) {
         return NO_DEVICE_PATTERN.test(output);
     }
     
    +function onConnect(couchdbURI, retryCount, callback) {
    --- End diff --
    
    Please give a more descriptive name to the function, since it's checking if a server is
up, not really opening a connection or handling an event (`onX` is a common naming pattern
for event handlers).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message