cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dblotsky <...@git.apache.org>
Subject [GitHub] cordova-medic pull request: CB-10405 - Connectivity issue to Cordo...
Date Fri, 22 Jan 2016 00:47:41 GMT
Github user dblotsky commented on a diff in the pull request:

    https://github.com/apache/cordova-medic/pull/72#discussion_r50488969
  
    --- Diff: medic/medic-run.js ---
    @@ -324,23 +349,8 @@ function main() {
             util.fatal("app " + appPath + " does not exist");
         }
     
    -    util.medicLog("checking if " + couchdbURI + " is up");
    -
    -    // check if results server is up
    -    request({
    -        uri:     couchdbURI,
    -        method:  "GET",
    -        timeout: SERVER_RESPONSE_TIMEOUT
    -    },
    -    function (error, response, body) {
    -
    -        // bail if the results server is down
    -        if (error || response.statusCode !== 200) {
    -            util.fatal("it's not up, so test run can't be monitored");
    -            process.exit(1);
    -        } else {
    -            util.medicLog("it's up");
    -        }
    +    onConnect(couchdbURI, 1, function(){
    --- End diff --
    
    Nitpick: please add a space between `function` and `()`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message