cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mvirkkunen <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser pull request: Make WP respect location...
Date Thu, 14 Jan 2016 00:14:29 GMT
Github user mvirkkunen commented on the pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/134#issuecomment-171479628
  
    As far as I could tell on Android at least it hides the bar with the back/next buttons.
It would also be in line with how browsers such as Chrome and Firefox react to location=no,
i.e. by hiding the back/next buttons (the actual address bar isn't hidden for security reasons).
    
    Also your README states that on Windows, "Please note that if location=no is also specified,
there will be no control presented to user to close IAB window.", which would further imply
that the purpose of location=no is to indeed hide the AppBar, which also has the close button.
    
    I do still need this and it feels like a feature that could be of use to others as well
- would it make more sense to implement it as a new platform-specific option, such as appbar=no?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message