cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: [CB-10274] Make www directory the defaul...
Date Tue, 05 Jan 2016 10:09:51 GMT
Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/360#discussion_r48829695
  
    --- Diff: cordova-lib/src/cordova/plugin.js ---
    @@ -186,6 +186,14 @@ module.exports = function plugin(command, targets, opts) {
                                     pluginInfoProvider: pluginInfoProvider
                                 };
     
    +                            if (!('www_dir' in options) || options.www_dir === undefined)
{
    --- End diff --
    
    IMO it is safe to remove this condition and always set `options.usePlatformWww = true`
because this code won't be called by plugman and CLI doesn't know anything about `www_dir`
option.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message