Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 909BB188B1 for ; Sat, 12 Dec 2015 05:55:36 +0000 (UTC) Received: (qmail 45660 invoked by uid 500); 12 Dec 2015 05:55:36 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 45619 invoked by uid 500); 12 Dec 2015 05:55:36 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 45607 invoked by uid 99); 12 Dec 2015 05:55:36 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 12 Dec 2015 05:55:36 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id D3FA9E08ED; Sat, 12 Dec 2015 05:55:35 +0000 (UTC) From: bso-intel To: dev@cordova.apache.org Reply-To: dev@cordova.apache.org Message-ID: Subject: [GitHub] cordova-lib pull request: Cb 7183 Content-Type: text/plain Date: Sat, 12 Dec 2015 05:55:35 +0000 (UTC) GitHub user bso-intel opened a pull request: https://github.com/apache/cordova-lib/pull/355 Cb 7183 CB-7183 security check for the scriptSrc property of the engine tag. The other src and target-dir path escape checks are already implemented in cordova-lib/src/plugman/platforms/common.js/copyFile() function. The only missing security check is in the scriptSrc of the tag. You can merge this pull request into a Git repository by running: $ git pull https://github.com/bso-intel/cordova-lib CB-7183 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/355.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #355 ---- commit 5fd5d275cd13ebe9eb3b7c86b71988cdcdfa4cf8 Author: Byoungro So Date: 2015-12-10T03:43:46Z CB-7183 prevent read/write/modify files outside project from plugins commit c03534aafc218923327ae7921eb75669927625d4 Author: Byoungro So Date: 2015-12-12T05:48:03Z CB-7183 security check for engine scriptSrc tag ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org For additional commands, e-mail: dev-help@cordova.apache.org