Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: daserge <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-45-cordova-plugin-splashscreen@git.apache.org>
In-Reply-To: <git-pr-45-cordova-plugin-splashscreen@git.apache.org>
Subject: [GitHub] cordova-plugin-splashscreen pull request: CB-10255 Add
 options to ...
Content-Type: text/plain
Message-Id: <20151223193414.4687ADFF73@git1-us-west.apache.org>
Date: Wed, 23 Dec 2015 19:34:14 +0000 (UTC)

Github user daserge commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-splashscreen/pull/45#discussion_r48373317
  
    --- Diff: src/android/SplashScreen.java ---
    @@ -255,6 +259,10 @@ public void run() {
                     }
                     splashDialog.setContentView(splashImageView);
                     splashDialog.setCancelable(false);
    +                if (isForceFullScreen()) {
    --- End diff --
    
    Does it make sense to move this to `// check to see if the splash screen should be full screen` condition above?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org