Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A162D1823C for ; Fri, 4 Dec 2015 14:00:53 +0000 (UTC) Received: (qmail 89115 invoked by uid 500); 4 Dec 2015 14:00:43 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 89073 invoked by uid 500); 4 Dec 2015 14:00:43 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 89062 invoked by uid 99); 4 Dec 2015 14:00:42 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Dec 2015 14:00:42 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 7DBD4E00B4; Fri, 4 Dec 2015 14:00:42 +0000 (UTC) From: m-revetria To: dev@cordova.apache.org Reply-To: dev@cordova.apache.org References: In-Reply-To: Subject: [GitHub] cordova-plugin-camera pull request: [iOS] Fixed authorization erro... Content-Type: text/plain Message-Id: <20151204140042.7DBD4E00B4@git1-us-west.apache.org> Date: Fri, 4 Dec 2015 14:00:42 +0000 (UTC) Github user m-revetria commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/144#issuecomment-161974581 I don't think this change completely fix the issue: we should check AVCaptureDevice auth status just when the picker source is the camera and check ALAssetsLibrary auth status just when the picker source type is photo library or saved photos album. Suppose next case: 1. open the image picker with source type camera 2. the user doesn't grant access to the device's camera 3. finally closes the UIImagePickerController by pressing the "Cancel" button. In that case the error message "no image selected" is returned, I would spect a message like "no access to camera". > Notice that this could happen just the first time the image picker is shown with source type camera, plugin is checking auth status before presenting the image picker. You can take a look to full auth check in my commit https://github.com/m-revetria/cordova-plugin-camera/commit/bbdafb08640cafc8e98ed0cbd5d558ad9b6dc150 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org For additional commands, e-mail: dev-help@cordova.apache.org