Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7C18418704 for ; Wed, 2 Dec 2015 23:27:43 +0000 (UTC) Received: (qmail 14173 invoked by uid 500); 2 Dec 2015 23:27:43 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 14131 invoked by uid 500); 2 Dec 2015 23:27:43 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 14120 invoked by uid 99); 2 Dec 2015 23:27:42 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Dec 2015 23:27:42 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id C0A96E67D2; Wed, 2 Dec 2015 23:27:42 +0000 (UTC) From: riknoll To: dev@cordova.apache.org Reply-To: dev@cordova.apache.org References: In-Reply-To: Subject: [GitHub] cordova-plugin-contacts pull request: CB-10039 Accept relative pat... Content-Type: text/plain Message-Id: <20151202232742.C0A96E67D2@git1-us-west.apache.org> Date: Wed, 2 Dec 2015 23:27:42 +0000 (UTC) Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/94#issuecomment-161466199 We really need to get all this file reading code in one place for Android. The camera plugin does things a bit differently (see [here](https://github.com/apache/cordova-plugin-camera/blob/master/src/android/FileHelper.java)). Is this the correct way to interpret relative paths? This assumes that they should be based on the assets root directory, but should it act like a web page and respect the file structure of the www folder? What do other platforms do? @jasongin thoughts? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org For additional commands, e-mail: dev-help@cordova.apache.org