Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: riknoll <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-142-cordova-plugin-camera@git.apache.org>
In-Reply-To: <git-pr-142-cordova-plugin-camera@git.apache.org>
Subject: [GitHub] cordova-plugin-camera pull request: Fix missing CAMERA
 permission ...
Content-Type: text/plain
Message-Id: <20151202200330.B3D1AE00DE@git1-us-west.apache.org>
Date: Wed,  2 Dec 2015 20:03:30 +0000 (UTC)

Github user riknoll commented on the pull request:

    https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161416757
  
    I feel like we can easily handle it, though, by programmatically checking if the permission was declared before we take a picture and only requesting it if it is (looks like it's in the [PackageInfo](http://developer.android.com/reference/android/content/pm/PackageInfo.html#requestedPermissions)). Plus, we avoid another quirk for the Android platform. Is there any danger in requesting that permission if some other plugin is already using it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org