cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jasongin <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-10125: Android build fails on read-on...
Date Thu, 03 Dec 2015 01:19:55 GMT
GitHub user jasongin opened a pull request:

    https://github.com/apache/cordova-lib/pull/351

    CB-10125: Android build fails on read-only image files

    Ensure image files are writeable before trying to delete them.
    
    I considered an alternative: ensuring files are writeable after copying them. But that
seemed less robust, and other parts of the build are already able to overwrite read-only files
due to the use of shell.cp('-f', ...). The only reason this code dealing with image files
had a problem was because it deleted the files before re-copying them.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jasongin/cordova-lib CB-10125

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/351.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #351
    
----
commit e5f55415876b819c98189549dbfd231595afdb11
Author: Jason Ginchereau <jasongin@microsoft.com>
Date:   2015-12-03T01:09:04Z

    CB-10125: Android build fails on read-only files

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message