cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From david-barth-canonical <>
Subject [GitHub] cordova-lib pull request: Cb 9618 - Icon parameter should not be r...
Date Wed, 02 Dec 2015 11:53:22 GMT
GitHub user david-barth-canonical opened a pull request:

    Cb 9618 - Icon parameter should not be relative to the www directory on Ubuntu

    This patch fixes a long standing issue, whereby the icon parameter in the app manifest
was prefixed with a www directory while it is not in other parts of the tools or runtime.

You can merge this pull request into a Git repository by running:

    $ git pull CB-9618

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #347
commit 4aa92493c36fef07415a0d0e6690464b2d21bd51
Author: David Barth <>
Date:   2015-09-07T15:38:27Z

    change iconPath to be relative to the project root directory, only; ie not to the www
sub-directory anymore

commit 67d2950d6106eaba031ece18b45cf4f8dea96f21
Author: David Barth <>
Date:   2015-09-23T10:50:05Z

    sync icon path lookup with the code in the manifest generation

commit 704c13d8616be9036bbcce25238ecd1a3f6731b1
Author: David Barth <>
Date:   2015-10-02T13:38:36Z

    don't add a leading www to the icon path when generating the desktop file


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message