cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From daserge <...@git.apache.org>
Subject [GitHub] cordova-labs pull request: CB-9840 Fallback file-transfer uploadRe...
Date Fri, 04 Dec 2015 12:27:58 GMT
GitHub user daserge opened a pull request:

    https://github.com/apache/cordova-labs/pull/10

    CB-9840 Fallback file-transfer uploadResponse encoding to latin1 in c…

    …ase not encoded with UTF-8 on iOS
    
    Adds non-utf endpoints for the correspoding tests: [filetransfer.spec.36](https://github.com/apache/cordova-plugin-file-transfer/blob/866349eb849e6260755d587066850c783d6bdb05/tests/tests.js#L739)
and [37](https://github.com/apache/cordova-plugin-file-transfer/blob/866349eb849e6260755d587066850c783d6bdb05/tests/tests.js#L1119).

    Implemented using [node-iconv](https://github.com/bnoordhuis/node-iconv).
    
    [Jira issue](https://issues.apache.org/jira/browse/CB-9840)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/daserge/cordova-labs cordova-filetransfer

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-labs/pull/10.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #10
    
----
commit 9f5e1a2e18a82891ce3b255fbee72f87cbc9dc3c
Author: daserge <v-seshak@microsoft.com>
Date:   2015-12-04T12:20:59Z

    CB-9840 Fallback file-transfer uploadResponse encoding to latin1 in case not encoded with
UTF-8 on iOS
    
    Adds non-utf endpoints for the correspoding tests: filetransfer.spec.36 and 37. Implemented
using node-iconv.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message