cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Steven Gill <stevengil...@gmail.com>
Subject Re: [DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)
Date Thu, 03 Dec 2015 20:26:40 GMT
When you do a cordova platform add https://github.com/apache/cordova-ubuntu,
our tools won't run npm install (it will soon though) when it fetches so
those node_modules will be missing. This issue won't exist when installing
from npm.

To solve this, we check node_modules into github.

On Thu, Dec 3, 2015 at 12:10 PM, David Barth <david.barth@canonical.com>
wrote:

> Shouldn't that be just pinned versions in package.json ?
>
> Can you share the install issues you had. I can compare and adjust quickly
> with a couple LXD containers.
>
> On Thu, Dec 3, 2015 at 7:03 PM, Carlos Santana <csantana23@gmail.com>
> wrote:
>
> > We should check into git repo node_modules
> > while recreating the archive I saw differences, I think this was due to
> the
> > npm version I used.
> > But adding from git is broken, since git doesn't node_modules (i.e.
> > shelljs, and others)
> > But this should not stop the release since the dist archive contains the
> > node_modules and from npm will have node_modules
> >
> >
> > On Wed, Dec 2, 2015 at 1:55 PM Steven Gill <stevengill97@gmail.com>
> wrote:
> >
> > > Okay sweet. Can you add a +1 on the vote thread that is open for
> Ubuntu.
> > We
> > > need one other committer to give a +1 so I can wrapnit up and publish
> > > On Dec 2, 2015 10:47 AM, "David Barth" <david.barth@canonical.com>
> > wrote:
> > >
> > > > On Tue, Dec 1, 2015 at 10:01 PM, Steven Gill <stevengill97@gmail.com
> >
> > > > wrote:
> > > >
> > > > > Which raw api changes to cordova@5.3.x make it unusable with
> ubuntu?
> > > As
> > > > > far
> > > > > as I know, cordova-ubuntu should work the same with cordova@4.x
> and
> > > > > cordova@5.x. The platform API changes aren't necessary to work
> with
> > > > > cordova@5.x
> > > > >
> > > >
> > > > It worked for most commands, except with options like build --device.
> > > This
> > > > is now fixed in 5.4 thanks to the recent cordova-lib commit.
> > > >
> > > >
> > > > >
> > > > > We probably won't do a update to cordova@4.x unless a security
> > concern
> > > > > comes up.
> > > > >
> > > >
> > > > Ok, makes sense. Anyway, I have a distro-patched version available in
> > an
> > > > Ubuntu PPA (personal archive) at :
> > > > https://launchpad.net/~cordova-ubuntu/+archive/ubuntu/ppa, for
> people
> > > who
> > > > want a quick start for Ubuntu only.
> > > >
> > > > I imagine it will be resolved by next month, and then I can propose a
> > > > debian package with cordova-cli 5 or 6 as well.
> > > >
> > > >
> > > > > Good idea to improve CB-9590. We are hoping to get cordova@6 out
> > next
> > > > week
> > > > > sometime. If we can get the fixes in by then, great!
> > > > >
> > > >
> > > > Ok
> > > >
> > > >
> > > > >
> > > > > Let me know how cordova-ubuntu@4.3.1 works with cordova-lib
> > (master).
> > > If
> > > > > thinks look good, we should get you and one other person to vote
on
> > the
> > > > > vote thread for cordova-ubuntu so I can officially release it on
> npm.
> > > > >
> > > >
> > > > I have finally been able to test with both cordova-cli @4.3.1 and
> > master,
> > > > ie 5.4.1 as published in npm, all from a clean VM running 14.04.2
> LTS,
> > > to:
> > > >
> > > > platform add ubuntu
> > > > build --device
> > > > run --device
> > > >
> > > > It is still not super pretty but there are no regressions and bugs
> are
> > > > fixed.
> > > >
> > > > So I would vote +1 for that cordova-ubuntu@4.3.1 to go in npm.
> > > >
> > > > David
> > > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message