cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Carlos Santana <csantan...@gmail.com>
Subject Re: [Android] Oops...we screwed up in Cordova-Android 5.0.x
Date Wed, 02 Dec 2015 04:21:48 GMT
Please update the doc reference, and also I think doing a short Blog Post
that explain the best practice on how this permission voodoo magic works
and how to handle in cordova apps with the API.

On Mon, Nov 30, 2015 at 6:44 PM Joe Bowser <bowserj@gmail.com> wrote:

> After thinking about this very hard, I don't think this needs to be added,
> because you can do this in your plugin code:
>
> cordova.getActivity().shouldShowRequestPermissionRationale(PERMISSION);
>
>
> And, in reality, all our method would do is turn this into this:
>
> cordova.shouldShowRequestPermissionRationale(PERMISSION);
>
>
> So, we're not actually adding any value to the developer. Perhaps we should
> just update the docs and move on? Maybe slate it for a later release when
> adding methods to CordovaInterface is not going to break people's custom
> WebView code?
>
> On Mon, Nov 30, 2015 at 12:43 PM, Simon MacDonald <
> simon.macdonald@gmail.com
> > wrote:
>
> > Hey Joe,
> >
> > My opinion is as long as we are not introducing a breaking change we
> don't
> > need to jump to 6.0.0. If we need to add a new method then we can
> probably
> > just bump it to 5.1.0.
> >
> > If you need an extra pair of hands to update the plugins just let me
> know.
> >
> > Simon
> > On Nov 30, 2015 04:21, "Terence M. Bandoian" <terence@tmbsw.com> wrote:
> >
> > > Do it right.  Damn the fallout.
> > >
> > > -Terence
> > >
> > > On 11/27/2015 4:51 PM, Joe Bowser wrote:
> > >
> > >> Hey
> > >>
> > >> So, I just came back from Android Dev Summit, and it turns out that we
> > >> didn't figure out how to use the
> > >> method shouldShowRequestPermissionRationale().  Here's the use case
> that
> > >> we
> > >> didn't figure out:
> > >>
> > >> If a user refuses a permission twice, they have the option of not
> > showing
> > >> the permission prompt ever again.  Basically, this is bad, and the
> user
> > >> should probably use the first callback to explain why this is an
> issue.
> > >> That said, if the user requests the permission a second time, Android
> > Best
> > >> Practices state that we should call
> > shouldShowRequestPermissionRationale()
> > >> and check to see if it was refused the first time, explain that the
> > >> permission requires this permission, and then prompt.
> > >>
> > >> Right now, we can't do that easily without adding an additional API
> call
> > >> on
> > >> the CordovaInterface.  I think that any changes to CordovaInterface
> > should
> > >> automatically prompt a major version update, so I don't want to do
> this.
> > >>
> > >> So, what should we do with this call? Ignore it? Call it inside the
> > >> plugin,
> > >> and have each plugin handle this independently?  I think that we
> should
> > >> have probably caught this when we were wishing we could explain why we
> > >> were
> > >> requesting certain permissions on our plugins, but hindsight is always
> > >> 20/20.
> > >>
> > >> So, thoughts on what we should do about this?  Make do without it?
> > >>
> > >> Joe
> > >>
> > >>
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > > For additional commands, e-mail: dev-help@cordova.apache.org
> > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message