cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shazron <shaz...@gmail.com>
Subject Re: [DISCUSS] cordova-ios 4.0.1 release
Date Wed, 16 Dec 2015 16:53:04 GMT
I'll fix it the issues. Please -1 so I can restart the vote after.

I was using the steps and may have missed one in trying to get it out
before I had to leave

On Wednesday, December 16, 2015, Homer, Tony <tony.homer@intel.com> wrote:

> I see the same thing as Carlos - version is still 4.0.0 in some places.
>
> [~]$ cordova create ios401test
> Creating a new cordova project.
> [~]$ cd ios401test/
> [~/ios401test]$ cordova platform add
> https://git-wip-us.apache.org/repos/asf/cordova-ios.git#4.0.1
> git cloning: https://git-wip-us.apache.org/repos/asf/cordova-ios.git#4.0.1
> Repository "https://git-wip-us.apache.org/repos/asf/cordova-ios.git"
> checked out to git ref "4.0.1".
> Adding ios project...
> iOS project created with cordova-ios@4.0.1
> ...
> [~/ios401test]$ cordova platform
> Installed platforms: ios 4.0.0
>
>
> It's not updated on the 4.0.1 tagged version in Apache git either:
>
> https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;a=shortlog;h=refs/tags/4.0.1
>
>
>
> (click tree, then navigate to, for example,
> bin/templates/scripts/cordova/version->raw)
>
> Regarding the missing tag on github, this is a problem on many releases.
> I'm not sure it's the same thing in this case, but per Steve there is a
> known infra issue when you push only a tag:
>
> "In terms of the tag and mirroring, here is the response I got from infra
> last time about android's tag and if it gets automatically updated.
> 'It is automated, however if you just updated a tag, the mirroring daemon
> will not sync as there is no substance to the change (same got for just
> creating a new branch with no changes).'
> You can just file an issue to infra and they can manual update it."
>
>
> On 12/16/15, 9:24 AM, "Carlos Santana" <csantana23@gmail.com
> <javascript:;>> wrote:
>
>
>
>
> >I see something weird.
> >Version was not updated from 4.0.0 to 4.0.1 in a couple of places.
> >
> >After creating an app I see 4.0.0 in:
> >platform/ios/cordova/version
> >platform/ios/www/cordova.js
> >Doing
> >$ cordova platform ls
> >Installed platforms: ios 4.0.0
> >Available platforms: amazon-fireos, android, blackberry10, browser,
> >firefoxos, osx, webos
> >
> >And in webview doing
> >cordova.version
> >"4.0.0"
> >
> >Did you use coho to cut the release? I thought that coho takes care of
> >updating the version with corresponding tag in multiple places including
> >adding cordova-js snapshot
> >
> >I see version updated to 4.0.1 in package.json and native
> CDVAvailability.h
> >
> >
> >git master doesn't point to 4.1.0-dev it points to 4.0.1 in package.json
> >
> >waiting on someone else to double check if I'm doing something wrong
> before
> >I send a stupid invalid -1 vote.
> >
> >
> >On Wed, Dec 16, 2015 at 9:12 AM Carlos Santana <csantana23@gmail.com
> <javascript:;>> wrote:
> >
> >> you can do this instead
> >> cordova platform add
> >> https://git-wip-us.apache.org/repos/asf/cordova-ios.git#4.0.1
> >>
> >>
> >> On Wed, Dec 16, 2015 at 9:01 AM Carlos Santana <csantana23@gmail.com
> <javascript:;>>
> >> wrote:
> >>
> >>> I see the tag 4.0.1 on apache git but I don't see it on github
> >>> So doing this fails cordova platform add
> >>> https://github.com/apache/cordova-ios#4.0.1
> >>>
> >>> I will continue verifying, just wanted to give a heads up, and see if
> its
> >>> an INFRA problem
> >>>
> >>>
> >>> On Tue, Dec 15, 2015 at 4:26 PM Shazron <shazron@gmail.com
> <javascript:;>> wrote:
> >>>
> >>>> I'll put out a VOTE thread later today based on the resolved issues
> >>>> here:
> >>>>
> https://issues.apache.org/jira/issues/?jql=labels%20%3D%20cordova-ios-4.0.1
> >>>>
> >>>> On Tue, Dec 15, 2015 at 10:02 AM, Carlos Santana <
> csantana23@gmail.com <javascript:;>>
> >>>> wrote:
> >>>> > https://issues.apache.org/jira/browse/CB-10156
> >>>> > seems odd, I left a request to add more info and sample plugin.
I'm
> OK
> >>>> not
> >>>> > to have in 4.0.1
> >>>> >
> >>>> > https://issues.apache.org/jira/browse/CB-10186
> >>>> > This is risky it can break a lot of things, not worth
> fixing/changing
> >>>> until
> >>>> > more investigation
> >>>> >
> >>>> > https://issues.apache.org/jira/browse/CB-10184
> >>>> > adding the new icon size for ipad pro seems small, to change the
> >>>> template
> >>>> > with new icon and update prepare.js
> >>>> > I think it will be good to have it fix in 4.0.1, but will not cry
if
> >>>> you
> >>>> > think is not urgent
> >>>> >
> >>>> > everything else I review the changes and seems reasonable.
> >>>> >
> >>>> >
> >>>> >
> >>>> > On Tue, Dec 15, 2015 at 10:26 AM Steven Gill <
> stevengill97@gmail.com <javascript:;>>
> >>>> wrote:
> >>>> >
> >>>> >> +1
> >>>> >> On Dec 15, 2015 2:04 AM, "Shazron" <shazron@gmail.com
> <javascript:;>> wrote:
> >>>> >>
> >>>> >> > All issues investigated and resolved for:
> >>>> >> >
> >>>> >>
> >>>>
> https://issues.apache.org/jira/issues/?jql=labels%20%3D%20cordova-ios-4.0.1
> >>>> >> >
> >>>> >> > 1 from the above is a https://www.npmjs.com/package/xcode
issue
> I
> >>>> think:
> >>>> >> >       https://issues.apache.org/jira/browse/CB-10156
> >>>> >> >
> >>>> >> > Punted more complex fixes to cordova-ios-4.1.0 since they
require
> >>>> >> > Platform API/template changes:
> >>>> >> >
> >>>> >>
> >>>>
> https://issues.apache.org/jira/issues/?jql=labels%20%3D%20cordova-ios-4.1.0
> >>>> >> >
> >>>> >> > On Mon, Dec 14, 2015 at 3:34 PM, Shazron <shazron@gmail.com
> <javascript:;>> wrote:
> >>>> >> > > Issues that are labeled 'cordova-ios-4.0.1'.
> >>>> >> > > Not all will be fixed for the release though.
> >>>> >> > >
> >>>> >> > >
> >>>> >> >
> >>>> >>
> >>>>
> https://issues.apache.org/jira/issues/?jql=labels%20%3D%20cordova-ios-4.0.1
> >>>> >> >
> >>>> >> >
> >>>> ---------------------------------------------------------------------
> >>>> >> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> <javascript:;>
> >>>> >> > For additional commands, e-mail: dev-help@cordova.apache.org
> <javascript:;>
> >>>> >> >
> >>>> >> >
> >>>> >>
> >>>>
> >>>> ---------------------------------------------------------------------
> >>>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> <javascript:;>
> >>>> For additional commands, e-mail: dev-help@cordova.apache.org
> <javascript:;>
> >>>>
> >>>>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message