cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Grebnov (Akvelon)" <v-seg...@microsoft.com>
Subject RE: Purpose of pre_package hook for windows
Date Thu, 10 Dec 2015 19:21:08 GMT
Hi guys, the pre_package hook was added before I've started working on new hook model so I
don't know much details about its original purpose.

There are still plugins[1] on github which reply on it, but not much.  I think pre_package
is identical to before_compile so this should be an easy fix. So probably we can just make
pre_package to be an alias for before_compile and deprecate/remove it after some time.

[1] https://github.com/search?p=1&q=pre_package+filename%3Aplugin.xml&ref=searchresults&type=Code&utf8=%E2%9C%93

Thx!
Sergey
-----Original Message-----
From: Jesse [mailto:purplecabbage@gmail.com] 
Sent: Wednesday, December 9, 2015 2:06 PM
To: dev@cordova.apache.org
Subject: Re: Purpose of pre_package hook for windows

I can't find any info on why we needed it ... it seems to be fired right before the files
are added to the csproj, though I am not sure why.

The only other person I think may know anything about it would be @sgrebnov

The earliest JIRA ticket I could find on the issue [1] although the issue is just that it
exists in wp7 but not wp8.


[1] https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-5261&data=01%7c01%7cv-segreb%40microsoft.com%7c53012f7781224cf8372e08d300e505dc%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=c9AEritc1dtKYjRmkqF2mv4Pb4ri9okjq6bV9gPqAFY%3d


@purplecabbage
https://na01.safelinks.protection.outlook.com/?url=risingj.com&data=01%7c01%7cv-segreb%40microsoft.com%7c53012f7781224cf8372e08d300e505dc%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=wW%2bKeY6MmNVcIOVrceLfhfpkMeUTCTbAsBrbCpkkXwg%3d

On Wed, Dec 9, 2015 at 11:53 AM, Vladimir Kotikov (Akvelon) < v-vlkoti@microsoft.com>
wrote:

> Hi, guys.
>
> Could anyone please shed some light on the subject?
>
> Looking into PR for 'nohooks' option [1] I realized that we have a 
> logic in Windows/wp8 parsers that fires a hooks, specific for these 
> particular platforms. I see 2 problems with this:
>
> 1.       This doesn't fits well into the concept of PlatformApi
>
> 2.       The original purpose of the hook is now lost. It was intended to
> be fired in the middle of prepare [2], to allow to modify www folder 
> before it will be packed into app package, but now  it get fired right 
> before the end of platform preparation, and hence almost equal to 'after_prepare'.
>
> So the question is, should we still have these hooks in new windows 
> platform? Or we can just move it into LIB and fire just after the 
> prepare and only for windows/wp8?
>
> [1] https://github.com/apache/cordova-lib/pull/353
> [2]
> https://github.com/apache/cordova-lib/commit/bd2c667e947b3fda05541e0d1
> a124d23df60a132
> ---------------
> Best regards, Vladimir
>
>
Mime
View raw message