cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-plugin-geolocation pull request: CB-10278 geolocation watc...
Date Wed, 30 Dec 2015 10:28:02 GMT
Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-geolocation/pull/63#discussion_r48596899
  
    --- Diff: www/android/geolocation.js ---
    @@ -38,21 +39,29 @@ module.exports = {
         },
     
         watchPosition: function(success, error, args) {
    +        var pluginWatchId = utils.createUUID();
    +
             var win = function() {
                 var geo = cordova.require('cordova/modulemapper').getOriginalSymbol(window,
'navigator.geolocation');
    -            geo.watchPosition(success, error, {
    +            pluginToNativeWatchMap[pluginWatchId] = geo.watchPosition(success, error,
{
                     enableHighAccuracy: args[1]
                 });
             };
             exec(win, error, "Geolocation", "getPermission", []);
    +
    +        return pluginWatchId;
         },
     
    -    clearWatch: function(success, error, args) {
    +    clearWatch: function(pluginWatchId) {
             var win = function() {
    -          var geo = cordova.require('cordova/modulemapper').getOriginalSymbol(window,
'navigator.geolocation');
    -          geo.clearWatch(args[0]);
    +            var nativeWatchId = pluginToNativeWatchMap[pluginWatchId];
    --- End diff --
    
    What will happen if there is no `pluginWatchId` in `pluginToNativeWatchMap`? How native
`geo.clearWatch` will behave if called with `undefined?`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message