cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From TheBosZ <...@git.apache.org>
Subject [GitHub] cordova-plugin-splashscreen pull request: CB-10255 Add options to ...
Date Wed, 23 Dec 2015 19:39:10 GMT
Github user TheBosZ commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-splashscreen/pull/45#discussion_r48373738
  
    --- Diff: src/android/SplashScreen.java ---
    @@ -255,6 +259,10 @@ public void run() {
                     }
                     splashDialog.setContentView(splashImageView);
                     splashDialog.setCancelable(false);
    +                if (isForceFullScreen()) {
    --- End diff --
    
    I was thinking about the same thing myself. The problem I think is how the full screen
is implemented. The way it's done there is the old-style (pre-4.1) way and I don't think it
hides the navigation bar.
    
    I unfortunately don't have access to a device that old so I didn't want to cause an error
with older phones.
    
    With some experimentation we could probably combine them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message