cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shazron <...@git.apache.org>
Subject [GitHub] cordova-plugin-splashscreen pull request: CB-9043 CB-10244 Fix the...
Date Wed, 23 Dec 2015 01:27:40 GMT
Github user shazron commented on the pull request:

    https://github.com/apache/cordova-plugin-splashscreen/pull/68#issuecomment-166773600
  
    Thanks @daserge 
    LGTM, but would appreciate adding tests in `tests/ios` for CB-10244 -- although doesn't
seem like the function is easily testable without a re-factor. Either add a test or file an
issue to add a test for this for later.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message