cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dpogue <>
Subject [GitHub] cordova-android pull request: CB-10014: Set gradle applicationId t...
Date Tue, 22 Dec 2015 06:08:30 GMT
Github user dpogue commented on the pull request:
    I think I'd agree that `def manifest = new XmlSlurper().parse(file("AndroidManifest.xml"))`
is better. In this case I was just trying to copy what already existed for reading the version
    It looks like the helpers use a slightly different method for parsing the config.xml:
    def doGetConfigXml() {
        def xml = file("res/xml/config.xml").getText()
        // Disable namespace awareness since Cordova doesn't use them properly
        return new XmlParser(false, false).parseText(xml)
    I'm not sure which approach is best. Maybe @infil00p or one of the Crosswalk devs has
a better idea of gradle best practices? (I'm pretty sure none of this is considered "best
practices" though)

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message