cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-8455 added --nohooks option
Date Fri, 18 Dec 2015 09:41:44 GMT
Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/353#discussion_r48008986
  
    --- Diff: cordova-lib/src/hooks/HooksRunner.js ---
    @@ -87,6 +93,12 @@ module.exports = HooksRunner;
      */
     module.exports.fire = globalFire;
     function globalFire(hook, opts) {
    +    if (isHookDisabled(opts, hook)) {
    +        /* jshint -W064 */
    --- End diff --
    
    Just a minor nit: do we need for this ignores? We don't have neither 'strict mode' nor
JSHint `newcap` option enabled, so this is probably just a no-op.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message