cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From daserge <...@git.apache.org>
Subject [GitHub] cordova-plugin-splashscreen pull request: Set scale type to CENTER...
Date Fri, 18 Dec 2015 08:09:58 GMT
Github user daserge commented on the pull request:

    https://github.com/apache/cordova-plugin-splashscreen/pull/52#issuecomment-165710372
  
    @trancee, the current implementation will also work if you have 'large margins (safe areas)'
according to the docs:
    
    > "SplashMaintainAspectRatio" preference is optional. If set to true, splash screen
drawable is not stretched to fit screen, but instead simply "covers" the screen, like CSS
"background-size:cover". This is very useful when splash screen images cannot be distorted
in any way, for example when they contain scenery or text. This setting works best with images
that have large margins (safe areas) that can be safely cropped on screens with different
aspect ratios.
    
    I agree regarding the preference-way; could you take a look at #57 and rework this to
be optional and defined by string constant for example (defaulting to `CENTER_CROP` to be
a non-breaking change)?
    `<preference name="SplashScaleType" value="CENTER_CROP|CENTER_INSIDE" />`
    
    You should probably send this proposal to the dev-list (dev@cordova.apache.org) so that
people could vote and discuss.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message