cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From csantanapr <>
Subject [GitHub] cordova-ios pull request: CB-10162 correct the paths for iOS icon ...
Date Wed, 09 Dec 2015 03:40:04 GMT
Github user csantanapr commented on a diff in the pull request:
    --- Diff: bin/templates/scripts/cordova/lib/prepare.js ---
    @@ -257,10 +257,11 @@ function handleBuildSettings(platformConfig, locations) {
         return Q();
    -function handleIcons(projectConfig, platformRoot) {
    +function handleIcons(projectConfig, platformRoot, locations) {
         var icons = projectConfig.getIcons('ios');
    -    var appRoot = projectConfig.path;
    +    var appRoot = path.dirname(projectConfig.path);
    +    var originalName = path.basename(locations.xcodeCordovaProj);
    --- End diff --
    no need to create a new variable originalName or add 3rd parameter, use the value already
provided here self.locations.xcodeCordovaProj

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message